Re: [PATCH 04/16] grep portability fix: don't use "-e" or "-q"

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2008, 22:45 UTC
Message-ID: <7v63vr4l48.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vr6ef4mqa.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 16 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> System V versions of grep (such as Solaris /usr/bin/grep)
>> don't understand either of these options. git's usage of
>
> It might be fair for other System V people to qualify the above statement
> with "Historic System V" (personally I felt that Solaris without xpg4 was
> unusable, and I wish you luck tackling it).
>
> More seriously, you would need to disable "when grepping work-tree,
> running the native grep is faster and just as capable" optimization in
> builtin-grep.c::grep_cache().  Treat these problematic System V platforms
> as if they are not __unix__.
>
> I am surprised that you did not have issues with "tail -n$number".
> Historic way to spell it was "tail -$number" wasn't it?

Heh, I notice you had to deal with these issues in the later patches ;-)