Re: [PATCH 11/16] config: add --literal-match option
- From
Jeff King <peff@peff.net>
- Date
- Mar 13, 2008, 12:42 UTC
- Message-ID
- <20080313124250.GD19485@coredump.intra.peff.net>
- In-Reply-To
- <7vejaf4lmc.fsf@gitster.siamese.dyndns.org>
On Wed, Mar 12, 2008 at 03:34:51PM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> > The patch is about twice as long as it needs to be since getting and > > setting in builtin-config follow two almost-the-same parallel codepaths. > > I suspect this could be cleaned up, but I didn't look too closely. > > I think that is a good new feature to propose. > > Historically, the config_set_multivar() function has been one of the most > buggy part of the then-current codebase. It might be a good idea to > clean-up first and then enhance. > > But in either case I am quite reluctant to touch this part of the code > right now before 1.5.5, especially without extra sets of eyeballs.
That sounds sensible. I will throw this on the backburner until post-1.5.5, then, and try to respin it with some config cleanups.
-Peff