Re: [PATCH 03/16] more tr portability test script fixes

From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Mar 13, 2008, 08:28 UTC
Message-ID: <20080313082807.GT10103@mail-vs.djpig.de>
In-Reply-To: <20080312213106.GD26286@coredump.intra.peff.net>

On Wed, Mar 12, 2008 at 05:31:06PM -0400, Jeff King wrote:

Show 10 quoted lines

> --- a/t/diff-lib.sh
> +++ b/t/diff-lib.sh
> @@ -21,8 +21,8 @@ compare_diff_raw_z () {
>      # Also we do not check SHA1 hash generation in this test, which
>      # is a job for t0000-basic.sh
>  
> -    tr '\000' '\012' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
> -    tr '\000' '\012' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2
> +    perl -pe 'y/\000/\012/' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
> +    perl -pe 'y/\000/\012/' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2

It might make sense performance-wise to integrate the job of the sed call into the perl call here. Haven't tested it, though.

Gruesse,

-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/