Re: [PATCH 16/16] t7505: use SHELL_PATH in hook

From

APAdam Piatyszek <ediap@users.sourceforge.net>

Date

Mar 13, 2008, 07:11 UTC

Message-ID

<47D8D39C.3070904@users.sourceforge.net>

In-Reply-To

<20080312214243.GQ26286@coredump.intra.peff.net>

Hi!

* Jeff King [12 III 2008 22:42]:

> The hook doesn't run properly under Solaris /bin/sh. Let's
> use the SHELL_PATH the user told us about already instead.

[...]

> --- a/t/t7505-prepare-commit-msg-hook.sh
> +++ b/t/t7505-prepare-commit-msg-hook.sh
> @@ -25,7 +25,8 @@ export FAKE_EDITOR
>  HOOKDIR="$(git rev-parse --git-dir)/hooks"
>  HOOK="$HOOKDIR/prepare-commit-msg"
>  mkdir -p "$HOOKDIR"
> -cat > "$HOOK" <<'EOF'
> +echo "#!$SHELL_PATH" > "$HOOK"
> +cat >> "$HOOK" <<'EOF'
>  #!/bin/sh

    ^^^^^^^^^
The above line should be removed in my humble opinion.

-- 
.:.  Adam Piatyszek (ediap)  .:.....................................:.
.:.  ediap@users.sourceforge.net  .:................................:.