Re: [PATCH] t/t6000lib.sh: tr portability fix fix

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Mar 14, 2008, 22:06 UTC
Message-ID: <47DAF6D2.7050808@nrlssc.navy.mil>
In-Reply-To: <20080314214550.GA18326@coredump.intra.peff.net>

Jeff King wrote:

Show 13 quoted lines

> On Fri, Mar 14, 2008 at 04:26:31PM -0500, Brandon Casey wrote:
> 
>> Here's the version with escaped dashes. If you do the sed version, it's
>> something to compare to for readability.
>>
>> [...]
>>
>> -		   '------------------------------' |
>> +		   '\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-' |
> 
> Ugh. How about:
> 
>   sed 'yA~`!@#$%^&*()_+={}[]|\;:"<>,/? A------------------------------A'

Not working. I get:

*   ok 33: bisection diff --bisect u5 ^U <= 0
sed: -e expression #1, char 64: unterminated `y' command
* FAIL 34: --bisect l5 ^root
        check_output  "git rev-list $_bisect_option l5 ^root"
sed: -e expression #1, char 64: unterminated `y' command
* FAIL 35: --bisect l5 ^root ^c3
        check_output  "git rev-list $_bisect_option l5 ^root ^c3"
sed: -e expression #1, char 64: unterminated `y' command
* FAIL 36: --bisect l5 ^root ^c3 ^b4

But this does:

sed 'yA~`!@#$%^&*()_+={}\[]|\\;:"<>,/? A------------------------------A'

I have to escape open bracket and backslash on my end (linux). :(

Have to leave now, so if that doesn't work for you (which I'm thinking it won't), I won't be able to test on my end for a while.

-brandon