Re: [PATCH 06/16] add test_cmp function for test scripts
- From
Jeff King <peff@peff.net>
- Date
- Mar 13, 2008, 12:08 UTC
- Message-ID
- <20080313120821.GA19485@coredump.intra.peff.net>
- In-Reply-To
- <7vmyp34mn6.fsf@gitster.siamese.dyndns.org>
On Wed, Mar 12, 2008 at 03:12:45PM -0700, Junio C Hamano wrote:
> I think I have an earlier round of this in 'pu'.
Oops, so you do. I remember discussing it but didn't recall a patch coming out of it.
I see you have queued mine now in pu over yours. I actually think yours looks a little nicer (you sanity-check the comparator, and you are more careful with stdin (something that I considered, but figured we could add if something actually broke)).
Any reason not to keep your existing one over mine?
-Peff