Re: [PATCH 10/16] add NO_EXTERNAL_GREP build option

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mar 13, 2008, 07:50 UTC
Message-ID: <47D8DCC0.9090303@viscovery.net>
In-Reply-To: <20080312213916.GK26286@coredump.intra.peff.net>

Jeff King schrieb:

Show 12 quoted lines

> Previously, we just chose whether to allow external grep
> based on the __unix__ define. However, there are systems
> which define this macro but which have an inferior group
> (e.g., one that does not support all options used by t7002).
> This allows users to accept the potential speed penalty to
> get a more consistent grep experience (and to pass the
> testsuite).
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This might have fallouts for msysgit (i.e., they need to define
> NO_EXTERNAL_GREP instead of relying on __unix__ not being defined).

You name it. Would you mind converting exec_grep() to use run_command(), too? Or better inline it since it won't do a lot more than run_command()? That way we at least won't get a broken git when I merge git.git that has this patch.

Thanks, -- Hannes