From: Jeff Hostetler Date: Tue, 22 Jun 2021 15:45:31 GMT Subject: Re: [PATCH v2 00/28] Builtin FSMonitor Feature Message-ID: <6d302977-5360-b257-c9c0-9744311c6fae@jeffhostetler.com> In-Reply-To: On 5/26/21 10:06 PM, Junio C Hamano wrote: > These new global symbols are introduced by the series, but never > used outside the file they are added to: > > fsmonitor-ipc.o - fsmonitor_ipc__get_path > fsmonitor-ipc.o - fsmonitor_ipc__get_state > fsmonitor-ipc.o - fsmonitor_ipc__send_command > > Perhaps make them file-scope static? I intended these to be part of the API for talking to a builtin FSMonitor. They are called from builtin/fsmonitor--daemon.c and t/helper/test-fsmonitor-client.c Jeff