From: Jonathan Tan Date: Fri, 26 May 2023 21:27:59 GMT Subject: Re: [PATCH v2 7/7] common: move alloc macros to common.h Message-ID: <20230526212759.2294075-1-jonathantanmy@google.com> In-Reply-To: <20230523192949.1271671-7-calvinwan@google.com> Calvin Wan writes: > alloc_nr, ALLOC_GROW, and ALLOC_GROW_BY are commonly used macros for > dynamic array allocation. Moving these macros to common.h focuses > alloc.[ch] to allocation for Git objects and additionally allows us to > remove inclusions to alloc.h from files that solely used the above > macros. > > Signed-off-by: Calvin Wan Ah, indeed, "alloc.h" was used for 2 different allocation-related things. This change makes sense, of course. Thanks for this patch set. Overall, it looks good (except for some minor comments that I've given in other emails).