From: Jonathan Tan Date: Fri, 26 May 2023 21:25:25 GMT Subject: Re: [PATCH v2 2/7] wrapper.h: move declarations for wrapper.c functions from git-compat-util.h Message-ID: <20230526212525.2293692-1-jonathantanmy@google.com> In-Reply-To: <20230523192949.1271671-2-calvinwan@google.com> Calvin Wan writes: > Since the functions in wrapper.c are widely used across the codebase, > include it by default in git-compat-util.h. A future patch will remove > now unnecessary inclusions of wrapper.h from other files. > > Signed-off-by: Calvin Wan Thanks. So currently, if you wanted to xmmap, you don't have to include wrapper.h, but if you wanted to read_in_full, you do. Making Git code treat functions like those 2 in the same way makes sense to me.