From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Wed, 21 Apr 2021 16:43:57 GMT
Subject: Re: [PATCH v4 11/11] test-lib: split up and deprecate test_create_repo()
Message-ID: <20210421164357.GZ2947267@szeder.dev>
In-Reply-To: <patch-11.11-311a9dba36-20210421T101156Z-avarab@gmail.com>

On Wed, Apr 21, 2021 at 12:15:16PM +0200, Ævar Arnfjörð Bjarmason wrote:
>  5. Since we don't need to move the .git/hooks directory we don't need

Again: Since we don't need to change directories....

>     the subshell here either.
> 
>     See 0d314ce834 for when the subshell use got introduced for the
>     convenience of not having to "cd" back and forth while setting up
>     the hooks.

I think this is worse and even more misleading than even v2 was, for
the reasons I mentioned earlier.