Re: [PATCH v4 00/13] New remote-hg helper
- From
Jeff King <peff@peff.net>
- Date
- Nov 2, 2012, 14:48 UTC
- Message-ID
- <20121102144827.GB11170@sigill.intra.peff.net>
- In-Reply-To
- <CAMP44s3UHQE69O__EVK29uN_VPdZN=a0-Gczeh-Tbjp1ZAAbJw@mail.gmail.com>
On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote:
Show 15 quoted lines
> > Turns out msysgit's remote-hg is not exporting the whole repository, > > that's why it's faster =/ > > It seems the reason is that it would only export to the point where > the branch is checked out. After updating the to the tip I noticed > there was a performance difference. > > I investigated and found two reasons: > > 1) msysgit's version doesn't export files twice, I've now implemented the same > 2) msysgit's version uses a very simple algorithm to find out file changes > > This second point causes msysgit to miss some file changes. Using the > same algorithm I get the same performance, but the output is not > correct.
Do you have a test case that demonstrates this? It would be helpful for reviewers, but also helpful to msysgit people if they want to fix their implementation.
-Peff