Re: [PATCH v4 00/13] New remote-hg helper

From: Jeff King <peff@peff.net>
Date: Oct 29, 2012, 22:06 UTC
Message-ID: <20121029220604.GA21712@sigill.intra.peff.net>
In-Reply-To: <CAMP44s1SLpNpbjRXF6QHrOTO=_1=wjPo1_kV3jZV-HXOYXPbnQ@mail.gmail.com>

On Mon, Oct 29, 2012 at 11:02:31PM +0100, Felipe Contreras wrote:

Show 7 quoted lines

> > If remote-hg is going to live in contrib, it probably makes sense to
> > have its tests live there, too, like subtree.
> 
> Probably, I'll check that option.
> 
> But eventually I think it should be installed by default, unless
> somebody can come up for a reason not to. For now contrib might be OK.

I would one day like to have it as part of the main distribution, too, but it would be nice to prove its worth in the field for a while first. I especially would like to find out how it compares in practice with the work that is in msysgit.

Show 6 quoted lines

> > It means less test exposure, but the robustness of the tests does
> > not have to be as high.  You could also have no tests, but since you
> > have them, it seems silly not to include them. People know that
> > items in contrib/ may not be as mature as the rest of git.
> 
> Yeah, it's only a matter of figuring out how to run them.

Subtree seems to copy substantial parts of t/Makefile, but I suspect you could get away with just using an "include". I'd also be OK with just including a test script that pulls in test-lib.sh, and letting people run it manually (the Makefile infrastructure is really about running a lot of tests, but if there's only one script, it's not so hard).

-Peff