Re: [PATCH 03/10] i18n: mark relative dates for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2012, 16:27 UTC
Message-ID: <xmqqzk9zdbf7.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120425152558.GC31026@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Nguyen Thai Ngoc Duy wrote:
>> 2012/4/25 Junio C Hamano <gitster@pobox.com>:
>
>>>> +     strbuf_addf(timebuf,
>>>> +              Q_("%lu year ago", "%lu years ago", (diff + 183) / 365),
>>>> +              (diff + 183) / 365);
>>>>  }
>>>
>>> This is just a tangent, but could we possibly come here and say "1 year
>>> ago"?
>>
>> Nice catch. Singular form here is unnecessary.
>
> I think Junio meant
>
> 			Q_("1 year ago", "%lu years ago", ...)

No, I was just being stupid---what I meant was that diff will be so large that this will always be feeding more than 1 to %lu, so the first template string will never be used.

But it cannot be N_("%lu years ago", number), as others correctly pointed out. We want to use ngettext() here, because it is not enough to know that number is always greater than 1 to correctly phrase this in some languages.