[PATCH] bundle: remove stray single-quote from error message
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 26, 2012, 05:53 UTC
- Message-ID
- <20120426055359.GA2483@burratino>
- In-Reply-To
- <CACsJy8CzNx9GP2PSszs2rrkQHr0P6fPVe4+-z4QXJ8k_4hqh9w@mail.gmail.com>
After running rev-list --boundary to retrieve the list of boundary commits, "git bundle create" runs its own revision walk. If in this stage git encounters an unfamiliar option, it writes a message with an unbalanced quotation mark:
error: unrecognized argument: --foo'
Drop the stray quote to match the "unrecognized argument: %s" message used elsewhere and save translators some work.
This is mostly a futureproofing measure: for now, the "rev-list --boundary" command catches most strange arguments on its own and the above message is not seen unless you try something esoteric like "git bundle create test.bundle --header HEAD".
Reported-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Nguyen Thai Ngoc Duy wrote:
> Yeah. I searched the code and that seems the only place with > unbalanced quotes (both single and double quotes). I'll leave it to > you to either drop it or add another one there.
Ok, here you go.
bundle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bundle.c b/bundle.c index d9cfd905..27ab32e4 100644 --- a/bundle.c +++ b/bundle.c @@ -289,7 +289,7 @@ int create_bundle(struct bundle_header *header, const char *path, argc = setup_revisions(argc, argv, &revs, NULL); if (argc > 1) - return error("unrecognized argument: %s'", argv[1]); + return error("unrecognized argument: %s", argv[1]); object_array_remove_duplicates(&revs.pending);
-- 1.7.10