Re: [PATCH 07/10] i18n: apply: mark strings for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2012, 22:50 UTC
Message-ID: <xmqqehrbbf4s.fsf@junio.mtv.corp.google.com>
In-Reply-To: <1335184230-8870-8-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 8 quoted lines

> @@ -886,17 +886,17 @@ static char *gitdiff_verify_name(const char *line, int isnull, char *orig_name,
> ...
>  		if (!another || memcmp(another, name, len + 1))
> -			die("git apply: bad git-diff - inconsistent %s filename on line %d", oldnew, linenr);
> +			die(_("git apply: bad git-diff - inconsistent %s filename on line %d"), oldnew, linenr);
>  		free(another);
>  		return orig_name;
>  	}

In this function, the parameter oldnew has "old" or "new" and the callers (gitdiff_oldname() and gitdiff_newname()) do not have it marked for translation. Even if they did, it would result in a lego composition, so you may have to switch between two translatable messages here.