Re: [PATCH] help: replace underlining "help -a" headers using hyphens with a blank line

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2012, 17:30 UTC
Message-ID: <xmqqpqavd8iv.fsf@junio.mtv.corp.google.com>
In-Reply-To: <1335352913-32684-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 10 quoted lines

> We want the underline to align with the text above, for example:
>
> This is a header
> ----------------
> content...
>
> Unfortunately calculating text length could get complicated because
> the text could be in any charset in translated Git. Avoid it and print
> a blank line (i.e. charset neutral) instead. Readability is not
> affected much. After the change we get:

When I said we do not need *pseudo* underline, I really meant it. I tentatively amended your patch to read like this:

    We used to underline a header text, like this:

        This is a header
        ----------------
        content...

    But calculating text length so that the dashes align with the text
    could get complicated because the text could be in any charset in
    translated Git.

    There is no point to use this pseudo underline; simply a blank
    line would do and it even makes it easier to read:

        This is a header

        content...

and adjusted the code to match, but it may make more sense to use the GIT_COLOR* stuff for this to highlight the header line, allowing us to lose the extra empty line.

This patch obviously conflicts with your own nd/columns so we may want to take this slowly and it is OK to wait until columns graduates.