Re: [PATCH 04/10] i18n: help: mark strings for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 23, 2012, 18:18 UTC
Message-ID: <xmqqaa22jor5.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120423163032.GF4832@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Nguyễn Thái Ngọc Duy wrote:
>
>> --- a/help.c
>> +++ b/help.c
>> @@ -217,8 +217,9 @@ void list_commands(const char *title, struct cmdnames *main_cmds,
>>  
>>  	if (main_cmds->cnt) {
>>  		const char *exec_path = git_exec_path();
>> -		printf("available %s in '%s'\n", title, exec_path);
>> -		printf("----------------");
>> +		printf_ln(_("available %s in '%s'"), title, exec_path);
>> +		/* TRANSLATORS: this must align with "available %s in '%s'" */
>> +		printf(_("----------------"));
>>  		mput_char('-', strlen(title) + strlen(exec_path));
>
> Yuck. :)

Yuck indeed. Do we even care these pseudo-underline? Wouldn't a simple and clean "blank line" look better?