Re: [PATCH 06/10] i18n: remote: mark strings for translation
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Apr 26, 2012, 01:12 UTC
- Message-ID
- <CACsJy8BNbRFKqBKYLR5OKOEPL3iMdjzfSrSAxSZ489nNNW6rVw@mail.gmail.com>
- In-Reply-To
- <xmqqaa1zbexh.fsf@junio.mtv.corp.google.com>
2012/4/26 Junio C Hamano <gitster@pobox.com>:
Show 13 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> @@ -761,7 +761,7 @@ static int remove_branches(struct string_list *branches)
>> unsigned char *sha1 = item->util;
>>
>> if (delete_ref(refname, sha1, 0))
>> - result |= error("Could not remove branch %s", refname);
>> + result |= error(_("Could not remove branch %s"), refname);
>> }
>
> This is an issue in the original, but almost all messages in this
> utility use sq around names of 'stuff' that can be specified by the end
> user when it appears as part of a sentence, but not here.If we are going to make a style consistency patch, should we also agree on (at least for this command) whether to write initial letter in capital or not?
-- Duy