git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6] submodule: fetch missing objects from default remote

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2026, 23:40 UTC
Message-ID
<xmqqzf4gzi4i.fsf@gitster.g>
In-Reply-To
<20260303234044.105157-1-nasser.grainawi@oss.qualcomm.com>
Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> writes:
Show 19 quoted lines
> When be76c21282 (fetch: ensure submodule objects fetched, 2018-12-06)
> added support for fetching a missing submodule object by id, it
> hardcoded the remote name as "origin" and deferred anything more
> complicated for a later patch. Implement the NEEDSWORK item to remove
> the hardcoded assumption by adding and using a submodule helper subcmd
> 'get-default-remote'. Fixing this lets 'git fetch --recurse-submodules'
> succeed when the fetched commit(s) in the superproject trigger a
> submodule fetch, and that submodule's default remote name is not
> "origin".
>
> Add non-"origin" remote tests to t5526-fetch-submodules.sh and
> t5572-pull-submodule.sh demonstrating this works as expected and add
> dedicated tests for get-default-remote.
>
> Signed-off-by: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
> Reviewed-by: Jacob Keller <jacob.keller@gmail.com>
> ---
> Removed the fetch progress output comparison from the tests as the
> ordering is unpredictable.

This has gone quiet. Shall we declare victory and mark the topic for 'next'?

Thanks.
Previous: Nasser Grainawi
Message 36 of 36 in “Fetch missing submodule objects from default remote”
  1. Fetch missing submodule objects from default remoteNasser Grainawi, Jan 12, 2026
  2. Jacob KellerJan 13, 2026
  3. Ben KnobleJan 13, 2026
  4. Nasser GrainawiJan 13, 2026
  5. D. Ben KnobleJan 14, 2026
  6. Junio C HamanoJan 14, 2026
  7. Ben KnobleJan 14, 2026
  8. Junio C HamanoJan 14, 2026
  9. Nasser GrainawiJan 14, 2026
  10. submodule: fetch missing objects from default remoteNasser Grainawi, Jan 14, 2026
  11. Nasser GrainawiJan 21, 2026
  12. submodule: fetch missing objects from default remoteNasser Grainawi, Jan 22, 2026
  13. Junio C HamanoJan 22, 2026
  14. Jacob KellerJan 22, 2026
  15. Junio C HamanoJan 22, 2026
  16. Junio C HamanoFeb 25, 2026
  17. Jacob KellerMar 2, 2026
  18. Nasser GrainawiFeb 27, 2026
  19. Junio C HamanoJan 22, 2026
  20. Junio C HamanoJan 23, 2026
  21. Junio C HamanoJan 24, 2026
  22. Junio C HamanoFeb 20, 2026
  23. Nasser GrainawiFeb 27, 2026
  24. submodule: fetch missing objects from default remoteNasser Grainawi, Mar 1, 2026
  25. Jacob KellerMar 2, 2026
  26. Junio C HamanoMar 2, 2026
  27. Junio C HamanoMar 3, 2026
  28. Nasser GrainawiMar 3, 2026
  29. Nasser GrainawiMar 3, 2026
  30. Junio C HamanoMar 3, 2026
  31. submodule: fetch missing objects from default remoteNasser Grainawi, Mar 3, 2026
  32. Ramsay JonesMar 3, 2026
  33. Junio C HamanoMar 3, 2026
  34. Nasser GrainawiMar 3, 2026
  35. submodule: fetch missing objects from default remoteNasser Grainawi, Mar 3, 2026
  36. Junio C HamanoMar 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.