Re: [PATCH] Fetch missing submodule objects from default remote

>
> When be76c2128234d94b47f7087152ee55d08bb65d88 added support for fetching
> a missing submodule object by id, it hardcoded the remote name as
> "origin" and deferred anything more complicated for a later patch.
> Implement the NEEDSWORK item to remove the hardcoded assumption by
> adding and using a submodule helper subcmd 'get-default-remote'. Fixing
> this lets 'git fetch --recurse-submodules' succeed when the fetched
> commit(s) in the superproject trigger a submodule fetch, and that
> submodule's default remote name is not "origin".
>
> Add non-"origin" remote tests to t5526-fetch-submodules.sh and
> t5572-pull-submodule.sh demonstrating this works as expected and add
> dedicated tests for get-default-remote.
>
> Signed-off-by: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
> ---
> The original commit was a bit over 7 years ago, so I guess it worked
> fine for most users. I've now run into cases where it doesn't work while
> using 'repo' tool manifests that use a non-"origin" remote name and
> contain projects with submodules.
>
> I kept this as a single commit because most of the code delta is in the new
> test for the new submodule helper command, but it could easily be split into
> two commits if that's preferred.
>
>  builtin/submodule--helper.c             |  38 +++++
>  submodule.c                             |  17 ++-
>  t/meson.build                           |   1 +
>  t/t5526-fetch-submodules.sh             |  52 +++++++
>  t/t5572-pull-submodule.sh               |  21 ++-
>  t/t7425-submodule-get-default-remote.sh | 186 ++++++++++++++++++++++++
>  6 files changed, 312 insertions(+), 3 deletions(-)
>  create mode 100755 t/t7425-submodule-get-default-remote.sh
>