Re: [PATCH v3] submodule: fetch missing objects from default remote
- From
Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
- Date
- Feb 27, 2026, 17:20 UTC
- Message-ID
- <CAFcKa=-hQUnYKRRZzjmiUBbLtnq-oMe6TbiXwro1WrjQxX+MMA@mail.gmail.com>
- In-Reply-To
- <xmqqzf53t3fm.fsf@gitster.g>
On Fri, Feb 20, 2026 at 4:12 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 35 quoted lines
> > Junio C Hamano <gitster@pobox.com> writes: > > >> ... > >> This test assumes that the first branch created by default is > >> 'master', which will break in one of the CI jobs: > >> > >> https://github.com/git/git/actions/runs/21304166518/job/61328461844#step:9:1942 > > > > For now, I've queued two fix-up patches on top of the posted patch > > to avoid CI breakages when the topic is merged to 'seen'. One is to > > rename t7425-submodule-get-default-remote.sh to t7426-submodule-get-default-remote.sh > > (both filename and the reference to it in t/meson.build), and the > > other one is the following. > > > > ----- >8 ----- > > Subject: [PATCH] SQUASH??? fixup > > > > The test as posted breaks when run with > > > > $ make WITH_BREAKING_CHANGES=YesPlease test > > > > as the added part assumes that the default branch name is "master". > > > > This band-aid is sufficient for the purpose of the maintainer to get > > the CI passing, but the real solution should probably be done better > > in such a way that the latter step does not have to rely on the > > creation of "anchorpoint" in the previous step. I'll leave it to > > the contributor of the topic. > > --- > > This was from about a month ago, and we haven't heard from you. > Will we see a hopefully small and final update [PATCH v4] of this > topic sometime soon? >
Yes, sorry about the delay. I was aiming for thorough and landed at tardy. I'll get my replies to your inline comments sent shortly and hopefully the v4 soon after that.