Re: [PATCH v5] submodule: fetch missing objects from default remote

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2026, 21:26 UTC
Message-ID: <xmqqms0obo5s.fsf@gitster.g>
In-Reply-To: <2e62dc94-b821-4815-8dd2-f806580d2027@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 27 quoted lines

>   + diff -u expect_fetch_custom actual_fetch_warnings_removed
>   --- expect_fetch_custom 2026-03-03 20:35:13.949600802 +0000
>   +++ actual_fetch_warnings_removed       2026-03-03 20:35:14.150601532 +0000
>   @@ -4,9 +4,9 @@
>    Fetching submodule sub1/subdir/deepsubmodule
>    Fetching submodule submodule
>    Fetching submodule submodule/subdir/deepsubmodule
>   -From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1
>   - * branch            43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD
>   -Fetching submodule sub1/subdir/deepsubmodule
>    From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/submodule
>     * branch            e38933e027ee8a2000f603124aa899302a09a51f -> FETCH_HEAD
>    Fetching submodule submodule/subdir/deepsubmodule
>   +From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1
>   + * branch            43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD
>   +Fetching submodule sub1/subdir/deepsubmodule
>   error: last command exited with $?=1
>   not ok 44 - fetch new submodule commits on-demand outside standard refspec with custom remote name
>
>   ...
>
>   $ 
>
> From which I guess that the order of the output is somewhat unpredictable.
>
> Also, other test files in that patch didn't fail for me with 'make test', but it
> could be possible that they are also flaky. I didn't look.

Ah, looks like the command tries to fetch from multiple places in parallel and it is up to the luck which one reports its result first? We probably do not want such a "human readable progress output should look exactly like this" test.

Thanks for reporting.