Re: [PATCH] Fetch missing submodule objects from default remote

From: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
Date: Jan 13, 2026, 22:41 UTC
Message-ID: <CAFcKa=_P8kUXvsuneQsoi=Bwbmc8U1kBv68fx4yq81vKBLkFEQ@mail.gmail.com>
In-Reply-To: <7FB6BFD0-4C54-4924-851E-D4B5C574D7FC@gmail.com>

On Tue, Jan 13, 2026 at 2:51 PM Ben Knoble <ben.knoble@gmail.com> wrote:

Show 9 quoted lines

>
>
>
> > Le 12 janv. 2026 à 16:36, Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> a écrit :
> >
> > When be76c2128234d94b47f7087152ee55d08bb65d88 added support for fetching
> > a missing submodule object by id, it
>
> Convention is to refer to published commits using the “reference” format supported by git log and git show :)

Oh, thanks for pointing that out! I missed it in the SubmittingPatches doc. If I end up sending a v2 I'll include the update, but I assume that alone isn't worth sending a new patch for?

If it helps to have it here, the corrected first paragraph should be:

When be76c21282 (fetch: ensure submodule objects fetched, 2018-12-06) added support for fetching a missing submodule object by id, it hardcoded the remote name as "origin" and deferred anything more complicated for a later patch. Implement the NEEDSWORK item to remove the hardcoded assumption by adding and using a submodule helper subcmd 'get-default-remote'. Fixing this lets 'git fetch --recurse-submodules' succeed when the fetched commit(s) in the superproject trigger a submodule fetch, and that submodule's default remote name is not "origin".