Re: [PATCH v2] submodule: fetch missing objects from default remote

From: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
Date: Jan 21, 2026, 00:48 UTC
Message-ID: <CAFcKa=9jRS2-6wdhUaV0riFNaM+WB60BMho3pYQs_YXU2EvB6Q@mail.gmail.com>
In-Reply-To: <20260114194815.1049888-1-nasser.grainawi@oss.qualcomm.com>

On Wed, Jan 14, 2026 at 12:48 PM Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> wrote:

>
> Signed-off-by: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>

I realized I missed adding Jacob's Reviewed-by.

Reviewed-by: Jacob Keller <jacob.keller@gmail.com>

Show 17 quoted lines

> diff --git a/t/t5572-pull-submodule.sh b/t/t5572-pull-submodule.sh
> index 45f384dd32..868dd6d130 100755
> --- a/t/t5572-pull-submodule.sh
> +++ b/t/t5572-pull-submodule.sh
> @@ -257,7 +257,26 @@ test_expect_success 'fetch submodule remote of different name from superproject'
>         git -C a-submodule reset --hard HEAD^^ &&
>
>         git -C child pull --no-recurse-submodules &&
> -       git -C child submodule update
> +       git -C child submodule update &&
> +       test_path_is_file child/a-submodule/moreecho.t
> +'
> +
> +test_expect_success 'fetch submodule remote of different non-origin name from superproject' '
> +       git -C child/a-submodule remote rename origin o2 &&
> +
> +       # Create commit that's unreachable from current master branch

The single quote in this comment is breaking the test. Sorry I didn't re-run the tests before sending the patch. I'll wait for any other comments and otherwise include this fix in a v3 tomorrow.

> diff --git a/t/t7425-submodule-get-default-remote.sh b/t/t7425-submodule-get-default-remote.sh

FYI, this test name conflicts with the new test added in topic ar/submodule-gitdir-tweak (they both use t7425). Renaming this test to 't7426-...' and updating the name in t/meson.build is sufficient to have all tests passing with 'seen'.