git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] make credential helpers builtins

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 13, 2020, 17:55 UTC
Message-ID
<xmqqv9hm2zxp.fsf@gitster.c.googlers.com>
In-Reply-To
<20200813151410.GA892741@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Thu, Aug 13, 2020 at 11:08:39AM -0400, Taylor Blau wrote:
>
>> On Thu, Aug 13, 2020 at 10:58:55AM -0400, Jeff King wrote:
>> > There's no real reason for credential helpers to be separate binaries. I
>> > did them this way originally under the notion that helper don't _need_
>> > to be part of Git, and so can be built totally separately (and indeed,
>> > the ones in contrib/credential are). But the ones in our main Makefile
>> > build on libgit.a, and the resulting binaries are reasonably large.
>> 
>> Could you clarify which helpers you mean here? Git's own
>> credential-cache and store make sense to convert, but the helpers in
>> contrib definitely don't.
>> 
>> For what it's worth, I'm almost positive that you mean the in-tree
>> helpers (where in-tree means "in git.git but not in contrib"), in which
>> case I'm in favor of this direcftion.
>
> Yes, I mean the helpers in the Makefile that we build and install by
> default with a regular "make".

Makes sense, especially because none of the in-tree ones need to link with any extra dependency at runtime, we do not even have to debate if dynamic linkage overhead still matters ;-)

Previous: Jeff KingNext: Jeff King
Message 14 of 36 in “slimming down installed size”
  1. 0/5 slimming down installed sizeJeff King, Aug 13, 2020
  2. 1/5 Makefile: drop builtins from MSVC pdb listJeff King, Aug 13, 2020
  3. Taylor BlauAug 13, 2020
  4. Jeff KingAug 13, 2020
  5. Derrick StoleeAug 13, 2020
  6. Jeff KingAug 13, 2020
  7. Johannes SchindelinAug 14, 2020
  8. Jeff KingAug 14, 2020
  9. Johannes SchindelinAug 17, 2020
  10. Jeff HostetlerAug 17, 2020
  11. 2/5 make credential helpers builtinsJeff King, Aug 13, 2020
  12. Taylor BlauAug 13, 2020
  13. Jeff KingAug 13, 2020
  14. Junio C HamanoAug 13, 2020
  15. 3/5 make git-bugreport a builtinJeff King, Aug 13, 2020
  16. Derrick StoleeAug 13, 2020
  17. Jeff KingAug 13, 2020
  18. Junio C HamanoAug 13, 2020
  19. Junio C HamanoAug 13, 2020
  20. Jeff KingAug 14, 2020
  21. Johannes SchindelinAug 14, 2020
  22. Jeff KingAug 14, 2020
  23. Junio C HamanoAug 13, 2020
  24. Johannes SchindelinAug 14, 2020
  25. Jeff KingAug 15, 2020
  26. Emily ShafferAug 17, 2020
  27. Junio C HamanoAug 17, 2020
  28. Jeff KingAug 17, 2020
  29. Emily ShafferAug 17, 2020
  30. 4/5 make git-fast-import a builtinJeff King, Aug 13, 2020
  31. 5/5 drop vcs-svn experimentJeff King, Aug 13, 2020
  32. Taylor BlauAug 13, 2020
  33. Jeff KingAug 13, 2020
  34. Johannes SchindelinAug 14, 2020
  35. Jeff KingAug 14, 2020
  36. Taylor BlauAug 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.