Re: [PATCH 3/5] make git-bugreport a builtin
- From
Jeff King <peff@peff.net>
- Date
- Aug 14, 2020, 10:05 UTC
- Message-ID
- <20200814100543.GA3312240@coredump.intra.peff.net>
- In-Reply-To
- <xmqqa6yy2yjb.fsf@gitster.c.googlers.com>
On Thu, Aug 13, 2020 at 11:25:44AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> Jeff King <peff@peff.net> writes: > > > macros). That could change eventually of course, but it's not like > > switching back to a stand-alone at that point is a big deal. > > If it is not a big deal, then I am fine, but at the same time it > becomes unclear why we can say "we can use X and Y niceties only > available for builtins".
I may have oversold those niceties in the commit message. It is really only saving us two lines of code, and it wouldn't be a big deal to revert it (in fact, if you're uncomfortable with that, we could leave the function otherwise intact).
-Peff