git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] drop vcs-svn experiment

From
Jeff King <peff@peff.net>
Date
Aug 13, 2020, 15:18 UTC
Message-ID
<20200813151831.GB892741@coredump.intra.peff.net>
In-Reply-To
<20200813151136.GC2244@syl.lan>
On Thu, Aug 13, 2020 at 11:11:36AM -0400, Taylor Blau wrote:
Show 16 quoted lines
> > So it seems like the result is not really usable by anybody in practice.
> > It would be wonderful if somebody wanted to pick up the topic again, and
> > potentially it's worth carrying around for that reason. But the flip
> > side is that people doing tree-wide operations have to deal with this
> > code.  And you can see the list with (replace "HEAD" with this commit as
> > appropriate):
> 
> I have nothing to add to this email other than to say that I think it
> makes sense to remove this. I agree it would be nice if somebody picked
> it up, but given that nothing has really changed since ~8 years ago, I
> think that it's unlikely to happen in the next ~8 years ;).
> 
> At least, it seems unlikely enough that dropping 2MB from the
> installation size is worth it. If someone *is* interested in picking it
> up, I'm sure that they won't have trouble finding this patch and
> reverting it.

TBH I care less about the installation size (which we could easily fix by just not installing git-remote-testsvn) and more that it's 3000 lines of basically-dead code. That keeps getting touched for tree-wide refactors (most recently for strvec, but my -Wunused-parameters series was the straw that caused me to just delete it instead).

I don't think resurrecting it will be quite as easy as reverting this. Because the rest of the code will move on, so it will probably need some fixups, depending on how long it has been. But those fixups are the exact same changes we're saving regular git developers from doing. So it's really just gambling that we won't need to do them (and also shifting the work from everybody onto whoever chooses to work on this).

It would be nice if it could be spun out independently, but it does use a bunch of data structures from libgit.a, which complicates that.

-Peff
Previous: Taylor BlauNext: Johannes Schindelin
Message 33 of 36 in “slimming down installed size”
  1. 0/5 slimming down installed sizeJeff King, Aug 13, 2020
  2. 1/5 Makefile: drop builtins from MSVC pdb listJeff King, Aug 13, 2020
  3. Taylor BlauAug 13, 2020
  4. Jeff KingAug 13, 2020
  5. Derrick StoleeAug 13, 2020
  6. Jeff KingAug 13, 2020
  7. Johannes SchindelinAug 14, 2020
  8. Jeff KingAug 14, 2020
  9. Johannes SchindelinAug 17, 2020
  10. Jeff HostetlerAug 17, 2020
  11. 2/5 make credential helpers builtinsJeff King, Aug 13, 2020
  12. Taylor BlauAug 13, 2020
  13. Jeff KingAug 13, 2020
  14. Junio C HamanoAug 13, 2020
  15. 3/5 make git-bugreport a builtinJeff King, Aug 13, 2020
  16. Derrick StoleeAug 13, 2020
  17. Jeff KingAug 13, 2020
  18. Junio C HamanoAug 13, 2020
  19. Junio C HamanoAug 13, 2020
  20. Jeff KingAug 14, 2020
  21. Johannes SchindelinAug 14, 2020
  22. Jeff KingAug 14, 2020
  23. Junio C HamanoAug 13, 2020
  24. Johannes SchindelinAug 14, 2020
  25. Jeff KingAug 15, 2020
  26. Emily ShafferAug 17, 2020
  27. Junio C HamanoAug 17, 2020
  28. Jeff KingAug 17, 2020
  29. Emily ShafferAug 17, 2020
  30. 4/5 make git-fast-import a builtinJeff King, Aug 13, 2020
  31. 5/5 drop vcs-svn experimentJeff King, Aug 13, 2020
  32. Taylor BlauAug 13, 2020
  33. Jeff KingAug 13, 2020
  34. Johannes SchindelinAug 14, 2020
  35. Jeff KingAug 14, 2020
  36. Taylor BlauAug 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.