Re: [PATCH 3/5] make git-bugreport a builtin
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Aug 13, 2020, 17:01 UTC
- Message-ID
- <f576fdce-9005-4653-3f91-0ddd2fff125d@gmail.com>
- In-Reply-To
- <20200813145936.GC891370@coredump.intra.peff.net>
On 8/13/2020 10:59 AM, Jeff King wrote:
Show 7 quoted lines
> There's no reason that bugreport has to be a separate binary. And since > it links against libgit.a, it has a rather large disk footprint. Let's > make it a builtin, which reduces the size of a stripped installation > from 24MB to 22MB. > > This also simplifies our Makefile a bit. And we can take advantage of > builtin niceties like RUN_SETUP_GENTLY.
I agree that this is a good change. I'm a bit surprised that a feature added so recently wasn't added as a builtin in the first place. Perhaps that was a conscious decision? Maybe it was just because there was some point in time where it might have been relegated to contrib.
Thanks, -Stolee