Re: [PATCH 3/5] make git-bugreport a builtin

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2020, 16:58 UTC
Message-ID: <xmqqv9hh2oq9.fsf@gitster.c.googlers.com>
In-Reply-To: <20200815063811.GA628010@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Where do we want to go with this? After the discussion and sleeping on
> it, I'm still of the mind that we should generally default things to
> being builtins unless there's an immediate need not to do so (like
> extra link dependencies). But I don't care _too_ much, so I'd rather
> eject this patch and move forward with the rest of the series if it's a
> sticking point. Thoughts?

I already said what needs to be said.

I do not care too deeply what we do now today either way, as long as people remember that we are interested in the version string, build options and external library versions of the "git" binary (for built-ins) and non-built-in binaries (like the remote helpers), and not as much interested in these traits of the "git-bugreport" binary itself, when we need to split "bugreport" out of builtins in the future.

Ironically, making it built-in eliminates the chance of sloppy code to report versions and other traits of git-bugreport that does not matter and is different from these traits of git itself, but it will make the technical burden larger if we ever need to split. It won't be just the matter of giving it a new cmd_main() and worry about the optional nongit setup.

Thanks.