git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] make git-bugreport a builtin

From
Jeff King <peff@peff.net>
Date
Aug 17, 2020, 21:40 UTC
Message-ID
<20200817214041.GA1854983@coredump.intra.peff.net>
In-Reply-To
<xmqqv9hh2oq9.fsf@gitster.c.googlers.com>
On Mon, Aug 17, 2020 at 09:58:54AM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Where do we want to go with this? After the discussion and sleeping on
> > it, I'm still of the mind that we should generally default things to
> > being builtins unless there's an immediate need not to do so (like
> > extra link dependencies). But I don't care _too_ much, so I'd rather
> > eject this patch and move forward with the rest of the series if it's a
> > sticking point. Thoughts?
> 
> I already said what needs to be said.

I guess my question was really: after the discussion do you think I'm being an idiot, to the point that you do not want to pick up the series?

It sounds like the answer is no, and...
Show 7 quoted lines
> I do not care too deeply what we do now today either way, as long as
> people remember that we are interested in the version string, build
> options and external library versions of the "git" binary (for
> built-ins) and non-built-in binaries (like the remote helpers), and
> not as much interested in these traits of the "git-bugreport" binary
> itself, when we need to split "bugreport" out of builtins in the
> future.

Yes, I agree that future changes to bugreport may need to keep that in mind (but my guess is that it won't even ever come up).

-Peff
Previous: Junio C HamanoNext: Emily Shaffer
Message 28 of 36 in “slimming down installed size”
  1. 0/5 slimming down installed sizeJeff King, Aug 13, 2020
  2. 1/5 Makefile: drop builtins from MSVC pdb listJeff King, Aug 13, 2020
  3. Taylor BlauAug 13, 2020
  4. Jeff KingAug 13, 2020
  5. Derrick StoleeAug 13, 2020
  6. Jeff KingAug 13, 2020
  7. Johannes SchindelinAug 14, 2020
  8. Jeff KingAug 14, 2020
  9. Johannes SchindelinAug 17, 2020
  10. Jeff HostetlerAug 17, 2020
  11. 2/5 make credential helpers builtinsJeff King, Aug 13, 2020
  12. Taylor BlauAug 13, 2020
  13. Jeff KingAug 13, 2020
  14. Junio C HamanoAug 13, 2020
  15. 3/5 make git-bugreport a builtinJeff King, Aug 13, 2020
  16. Derrick StoleeAug 13, 2020
  17. Jeff KingAug 13, 2020
  18. Junio C HamanoAug 13, 2020
  19. Junio C HamanoAug 13, 2020
  20. Jeff KingAug 14, 2020
  21. Johannes SchindelinAug 14, 2020
  22. Jeff KingAug 14, 2020
  23. Junio C HamanoAug 13, 2020
  24. Johannes SchindelinAug 14, 2020
  25. Jeff KingAug 15, 2020
  26. Emily ShafferAug 17, 2020
  27. Junio C HamanoAug 17, 2020
  28. Jeff KingAug 17, 2020
  29. Emily ShafferAug 17, 2020
  30. 4/5 make git-fast-import a builtinJeff King, Aug 13, 2020
  31. 5/5 drop vcs-svn experimentJeff King, Aug 13, 2020
  32. Taylor BlauAug 13, 2020
  33. Jeff KingAug 13, 2020
  34. Johannes SchindelinAug 14, 2020
  35. Jeff KingAug 14, 2020
  36. Taylor BlauAug 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.