Re: [PATCH v2 6/7] color: support "italic" attribute

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2016, 18:34 UTC
Message-ID: <xmqqtwgjiwkn.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160623173907.GF15774@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> We already support bold, underline, and similar attributes.
> Let's add italic to the mix.  According to the Wikipedia
> page on ANSI colors, this attribute is "not widely
> supported", but it does seem to work on my xterm.
> ...
> @@ -133,6 +133,7 @@ static int parse_attr(const char *name, size_t len)
>  #define ATTR(x, val, neg) { (x), strlen(x), (val), (neg) }

I see this one was from an earlier reroll that did not use sizeof(x)-1; easy to fixup, though ;-)

Show 36 quoted lines

>  		ATTR("bold",      1, 22),
>  		ATTR("dim",       2, 22),
> +		ATTR("italic",    3, 23),
>  		ATTR("ul",        4, 24),
>  		ATTR("blink",     5, 25),
>  		ATTR("reverse",   7, 27)
> diff --git a/color.h b/color.h
> index e24fa0b..3af01a6 100644
> --- a/color.h
> +++ b/color.h
> @@ -16,7 +16,8 @@ struct strbuf;
>   *
>   * The space for attributes is also slightly overallocated, as
>   * the negation for some attributes is the same (e.g., nobold and nodim).
> - * We also allocate space for 6 attributes (even though we have only 5).
> + *
> + * We allocate space for 6 attributes.
>   */
>  #define COLOR_MAXLEN 70
>  
> diff --git a/t/t4026-color.sh b/t/t4026-color.sh
> index 2065752..13690f7 100755
> --- a/t/t4026-color.sh
> +++ b/t/t4026-color.sh
> @@ -60,8 +60,9 @@ test_expect_success 'long color specification' '
>  
>  test_expect_success 'absurdly long color specification' '
>  	color \
> -	  "#ffffff #ffffff bold nobold dim nodim ul noul blink noblink reverse noreverse" \
> -	  "[1;2;4;5;7;22;24;25;27;38;2;255;255;255;48;2;255;255;255m"
> +	  "#ffffff #ffffff bold nobold dim nodim italic noitalic
> +	   ul noul blink noblink reverse noreverse" \
> +	  "[1;2;3;4;5;7;22;23;24;25;27;38;2;255;255;255;48;2;255;255;255m"
>  '
>  
>  test_expect_success '0-7 are aliases for basic ANSI color names' '