[PATCH 0/2] more ANSI attributes

From: Jeff King <peff@peff.net>
Date: Jun 23, 2016, 13:08 UTC
Message-ID: <20160623130828.GA25209@sigill.intra.peff.net>
In-Reply-To: <etPan.576bcdfa.7aee6fa4.9bf5@cubyx.fr>

On Thu, Jun 23, 2016 at 01:54:34PM +0200, Simon Courtois wrote:

Show 7 quoted lines

> I was looking for a way to use italics in my git log. I ended-up
> looking at the code dealing with colors and style and noticed that the
> italic code was skipped when defining the list (color.c:128 if I'm not
> mistaken).
> 
> I'd love to propose a contribution but I'm sadly not very well versed
> with C.

My first suggestion was going to be that you can feed arbitrary numbers yourself, without git having to have a name for it. But that is true only of colors, not attributes. So it does need a patch.

Here is one, along with a minor cleanup. I think the attributes we don't support now are:

  - 6; rapid blink (not supported by xterm)
  - 8; conceal (supported, but why would you want it?)
  - 9; crossed-out (supported, and at least plausible to want?)

We also don't support font-selection (10-19, or 20 for Fraktur) which are not supported by xterm (of course xterm support is not the defining criterion, if people have other terms that do support it. My point is mostly "nobody is asking for it, and it is not even in xterm").

  [1/2]: color: fix max-size comment
  [2/2]: color: support "italic" attribute

-Peff