Re: [PATCH v2 7/7] color: support strike-through attribute

From: Jeff King <peff@peff.net>
Date: Jun 23, 2016, 18:39 UTC
Message-ID: <20160623183907.GA32368@sigill.intra.peff.net>
In-Reply-To: <xmqqpor7iwgo.fsf@gitster.mtv.corp.google.com>

On Thu, Jun 23, 2016 at 11:36:23AM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > This is the only remaining attribute that is commonly
> > supported (at least by xterm) that we don't support. Let's
> > add it for completeness.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > This was mostly for fun.  I can't think of a way in which it would be
> > useful, and I'm not sure how compelling completionism is as an argument
> > for inclusion. I'm OK if we drop this one.
> 
> It indeed is fun and it even makes sense in this context:
> 
>     $ ./git -c diff.color.old='red strike' show

Ooh, I hadn't thought of that. It's a bit noisy for my tastes in a line-oriented diff, but with --color-words, it actually helps quite a bit (try it on the documentation patch from this series, for example).

-Peff