Re: [PATCH 2/2] color: support "italic" attribute

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2016, 16:46 UTC
Message-ID: <xmqq7fdfkg3i.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160623131028.GB12653@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 24 quoted lines

> We already support bold, underline, and similar attributes.
> Let's add italic to the mix.  According to the Wikipedia
> page on ANSI colors, this attribute is "not widely
> supported", but it does seem to work on my xterm.
>
> We don't have to bump the maximum color size because we were
> already over-allocating it (but we do adjust the comment
> appropriately).
>
> Requested-by: Simon Courtois <scourtois@cubyx.fr>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  Documentation/config.txt | 2 +-
>  color.c                  | 8 ++++----
>  color.h                  | 3 ++-
>  t/t4026-color.sh         | 4 ++--
>  4 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 58673cf..4b97d8d 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -154,7 +154,7 @@ color::
>         colors (at most two) and attributes (at most one), separated

This is describing the format accepted by color_parse_mem(), whose main loop has /* [fg [bg]] [attr]... */ comment in front?

Is "at most one" still correct, or it was already stale before this patch?