Re: [PATCH v2 7/7] color: support strike-through attribute

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2016, 18:52 UTC
Message-ID: <xmqqlh1vivp8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160623183907.GA32368@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 21 quoted lines

> On Thu, Jun 23, 2016 at 11:36:23AM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > This is the only remaining attribute that is commonly
>> > supported (at least by xterm) that we don't support. Let's
>> > add it for completeness.
>> >
>> > Signed-off-by: Jeff King <peff@peff.net>
>> > ---
>> > This was mostly for fun.  I can't think of a way in which it would be
>> > useful, and I'm not sure how compelling completionism is as an argument
>> > for inclusion. I'm OK if we drop this one.
>> 
>> It indeed is fun and it even makes sense in this context:
>> 
>>     $ ./git -c diff.color.old='red strike' show
>
> Ooh, I hadn't thought of that. It's a bit noisy for my tastes in a
> line-oriented diff, but with --color-words, it actually helps quite a
> bit (try it on the documentation patch from this series, for example).

What I usually use is diff.color.old='red reverse' because I cannot easily tell between black and dark red in small font on my white background. s/reverse/strike/ makes it much less noisy.

What is sad for me is that I usually work in GNU screen, displaying on either xterm or gnome-terminal. Without screen, strike shows but inside it I cannot seem to be able to get strike-thru in effect.