Re: [PATCH 2/2] color: support "italic" attribute

From: Jeff King <peff@peff.net>
Date: Jun 23, 2016, 16:47 UTC
Message-ID: <20160623164751.GA29882@sigill.intra.peff.net>
In-Reply-To: <xmqq7fdfkg3i.fsf@gitster.mtv.corp.google.com>

On Thu, Jun 23, 2016 at 09:46:57AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> > diff --git a/Documentation/config.txt b/Documentation/config.txt
> > index 58673cf..4b97d8d 100644
> > --- a/Documentation/config.txt
> > +++ b/Documentation/config.txt
> > @@ -154,7 +154,7 @@ color::
> >         colors (at most two) and attributes (at most one), separated
> 
> This is describing the format accepted by color_parse_mem(), whose
> main loop has /* [fg [bg]] [attr]... */ comment in front?
> 
> Is "at most one" still correct, or it was already stale before this
> patch?

I think it was already stale.

I'm actually preparing a re-roll that makes some of the parsing a bit less nasty, too. I'll fix that at the same time.

-Peff