Re: [PATCH] config.mak.dev: enable -Wunreachable-code

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2025, 18:50 UTC
Message-ID: <xmqqsenk7mab.fsf@gitster.g>
In-Reply-To: <20250310160440.GA26189@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Maybe not often, if there is only one instance in the current code base.
> Or maybe a lot, but we wouldn't know because we haven't had the warning
> enabled.
>
> I guess another option is to enable it in _one_ CI job that uses clang
> on Linux (maybe linux-sha256?) and see how often it is helpful or
> harmful.

The reason why you said Linux rather than macOS is because the single instance we know about would not have to be worked around if we did it that way?

I am OK with that.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.