Re: [PATCH] config.mak.dev: enable -Wunreachable-code

From: Mike Hommey <mh@glandium.org>
Date: Jun 3, 2025, 23:08 UTC
Message-ID: <20250603230821.qig7g4zsenunlkbh@glandium.org>
In-Reply-To: <20250603223750.sjp5rw56ajehaaqe@glandium.org>

On Wed, Jun 04, 2025 at 07:37:50AM +0900, Mike Hommey wrote:

Show 26 quoted lines

> On Tue, Jun 03, 2025 at 03:07:36PM -0700, Junio C Hamano wrote:
> > Mike Hommey <mh@glandium.org> writes:
> > 
> > > There is a similar problem with this code in refs/files-backend.c:
> > >
> > > 			if (!create_ref_symlink(lock, update->new_target))
> > > 				continue;
> > >
> > > Where create_ref_symlink is defined as such:
> > >
> > > #ifdef NO_SYMLINK_HEAD
> > > #define create_ref_symlink(a, b) (-1)
> > > #else
> > > static int create_ref_symlink(struct ref_lock *lock, const char *target)
> > > {
> > > ...
> > > #endif
> > >
> > > And NO_SYMLINK_HEAD is defined on Windows.
> > 
> > Would the NOT_CONSTANT() trick we ended up using for the original
> > "sigfillset" thing solve your issue as well?
> 
>    if (NOT_CONSTANT(!create_ref_symlink(lock, update->new_target)))
> 
> indeed works around it.

I sent it as a patch along with other warning fixes.

Mike