Re: [PATCH v3 2/3] git-compat-util: add NOT_CONSTANT macro and use it in atfork_prepare()

From: Calvin Wan <calvinwan@google.com>
Date: Mar 18, 2025, 22:26 UTC
Message-ID: <CAFySSZC=qxs43ahZSRUeFxFTXDq905OdZ8-4beGUoaScaj=ugg@mail.gmail.com>
In-Reply-To: <20250318220453.1937685-1-calvinwan@google.com>

On Tue, Mar 18, 2025 at 3:05 PM Calvin Wan <calvinwan@google.com> wrote:

Show 11 quoted lines

>
> Junio C Hamano <gitster@pobox.com> writes:
> > Our hope is that the number of code paths that falsely trigger
> > @@ -985,6 +985,7 @@ LIB_OBJS += compat/nonblock.o
> >  LIB_OBJS += compat/obstack.o
> >  LIB_OBJS += compat/terminal.o
> >  LIB_OBJS += compat/zlib-uncompress2.o
> > +LIB_OBJS += compiler-tricks/not-a-constant.o
>
> The name is correctly added here, but in `next,` this name is set to
> `compiler-tricks/not-constant.o`.

Apologies you can ignore this -- we needed to add a reference to the new folder internally so this was a red herring for our broken build.