Re: [PATCH] config.mak.dev: enable -Wunreachable-code
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 3, 2025, 22:07 UTC
- Message-ID
- <xmqqh60wh42f.fsf@gitster.g>
- In-Reply-To
- <20250603212934.uojo22zjcuf6yfic@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 16 quoted lines
> There is a similar problem with this code in refs/files-backend.c:
>
> if (!create_ref_symlink(lock, update->new_target))
> continue;
>
> Where create_ref_symlink is defined as such:
>
> #ifdef NO_SYMLINK_HEAD
> #define create_ref_symlink(a, b) (-1)
> #else
> static int create_ref_symlink(struct ref_lock *lock, const char *target)
> {
> ...
> #endif
>
> And NO_SYMLINK_HEAD is defined on Windows.Would the NOT_CONSTANT() trick we ended up using for the original "sigfillset" thing solve your issue as well?