Re: [PATCH v2 2/3] run-command: use errno to check for sigfillset() error

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 17, 2025, 21:30 UTC
Message-ID: <Z9iUe3Hg30W5LFSZ@nand.local>
In-Reply-To: <20250314210909.3776678-3-gitster@pobox.com>

On Fri, Mar 14, 2025 at 02:09:08PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> From: Jeff King <peff@peff.net>
>
> Since enabling -Wunreachable-code, builds with clang on macOS now fail,
> complaining that the die_errno() call in:
>
>   if (sigfillset(&all))
> 	die_errno("sigfillset");

Hmm. Would it have made sense to swap the order of this and the first patch so we don't have a DEVELOPER=1 breakage (for macOS with Clang) in history?

I think it's too late now since this topic is already on 'next', but it occurred to me idly while reading this patch.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.