Re: [PATCH v3 2/3] git-compat-util: add NOT_CONSTANT macro and use it in atfork_prepare()

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 18, 2025, 23:55 UTC
Message-ID: <xmqqh63pzyg3.fsf@gitster.g>
In-Reply-To: <CAFySSZC=qxs43ahZSRUeFxFTXDq905OdZ8-4beGUoaScaj=ugg@mail.gmail.com>

Calvin Wan <calvinwan@google.com> writes:

Show 15 quoted lines

> On Tue, Mar 18, 2025 at 3:05 PM Calvin Wan <calvinwan@google.com> wrote:
>>
>> Junio C Hamano <gitster@pobox.com> writes:
>> > Our hope is that the number of code paths that falsely trigger
>> > @@ -985,6 +985,7 @@ LIB_OBJS += compat/nonblock.o
>> >  LIB_OBJS += compat/obstack.o
>> >  LIB_OBJS += compat/terminal.o
>> >  LIB_OBJS += compat/zlib-uncompress2.o
>> > +LIB_OBJS += compiler-tricks/not-a-constant.o
>>
>> The name is correctly added here, but in `next,` this name is set to
>> `compiler-tricks/not-constant.o`.
>
> Apologies you can ignore this -- we needed to add a reference to the new folder
> internally so this was a red herring for our broken build.

Sorry, I may not have sent a reroll to the list for the version that went into 'next'. It should have lost "a" from not-constant consistently everywhere.

Thanks for being eagle-eyed.