Re: [RFC PATCH] show decorations at the end of the line

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2017, 20:11 UTC
Message-ID: <xmqqpoibfgo3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFwdUxCvmi28T3yn1K4rqn2bZmJBdTRr7tSbMa-g5izHbw@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 6 quoted lines

> That source showing should never have been in "show_decorations()" in
> the first place. It just happened to be a convenient place for it.
>
> So this attached patch is just my original patch updated to split up
> "show_source()" from "show_decorations()", and show it where it used
> to be.

The updated organization smells a lot better to me ;-)

Most of the time it is convenient to have "show source" at the beginning of a single helper that is to show both, but oneline format is so special that it makes it inconvenient to have them at the same place.

I can lose the patch to 4202 (update the expectation for --source) I added to the previous one, but the patch to 4207 (update the expectation for --decorate) needs to be kept with this round.

Will replace; thanks.