Re: [RFC PATCH] show decorations at the end of the line

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2017, 08:30 UTC
Message-ID: <xmqq1sv2fq6m.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFw2S14a4_4YK0b6PNK4TH_AUo_+2JN+PTyBTufNeB5t6A@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 10 quoted lines

> On Sat, Feb 11, 2017 at 10:02 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> I've signed off on this, because I think it's an "obvious" improvement,
>> but I'm putting the "RFC" in the subject line because this is clearly a
>> subjective thing.
>
> Side note: the one downside of showing the decorations at the end of
> the line is that now they are obviously at the end of the line - and
> thus likely to be more hidden by things like line truncation.

Side note: I refrained from commenting on this patch because everybody knows that the what I would say anyway ;-) and I didn't want to speak first to discourage others from raising their opinion.

An obvious downside is that people (against all recommendations) are likely to have written a loose script expecting the --oneline format is cast in stone. I personally think it is OK to break them as long as "workaround" (aka kosher way to do what they have been doing) is obvious and easily doable, and in this case their script can switch to use --format to keep using the order of fields and format they have been relying on.

It would be nice if we can have that --format string they can use somewhere in the log message, so that I can cut & paste it into the release notes that contains this change (i.e. "those who want to keep using the traditional --oneline --decorate can use this string as pretty.my1line configuration variable and use --pretty=my1line instead").