Re: [RFC PATCH] show decorations at the end of the line

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 18, 2017, 05:27 UTC
Message-ID: <xmqqefywnk5a.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170215002901.gtzegvhyy7d6cvrb@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

>> The updates to the expectation look like this (already squashed).
>> The --source decorations in 4202 are also shown at the end, which
>> probably is in line with the way --show-decorations adds them at the
>> end of the line, but was somewhat surprising from reading only the
>> log message.
>
> Hrm, that does surprise me. I'm not sure if that's desirable or not. I
> do think some of the "nobody could possibly be parsing these" arguments
> about decorations do not apply to --source (and also, they're harder for
> humans to pick out from the end of the line as they lack punctuation and
> color).

I just got bitten by a fallout.  I have

    $ git recent --help
    `git recent' is aliased to `log --oneline --branches --no-merges \
	 --source --since=3.weeks'

and often do

    $ git recent name-hash.c

primarily to see if I already queued a patch series to a topic (and forgot about it), and/or what other recent topics in flight touch the same thing.

I'd need that the topic name to be shown rather prominently for this use case, i.e.

    eb2263adb1      jh/memihash-opt name-hash: remember previous dir_...
    0c04267dc8      jh/memihash-opt name-hash: specify initial size f...
    57463ce445      jh/memihash-opt name-hash: precompute hash values...
    dd3170e2cf      jh/memihash-opt name-hash: eliminate duplicate me...

but now the branch names are shown at the end, which defeats the whole point of the alias.

If nobody gets around to fixing it, I may take a look at it when able, but for now let me just vent^Wreport a regression first.