Re: [RFC PATCH] show decorations at the end of the line

From: Jacob Keller <jacob.keller@gmail.com>
Date: Feb 19, 2017, 23:03 UTC
Message-ID: <CA+P7+xqtPwzt3J6O05TP=E_hh-ko97adn+__Zmc0DNSDqEnEHw@mail.gmail.com>
In-Reply-To: <CA+55aFw3ZRtgsLGW-TFqpq-3uCw55L42p7cF=Q-73qM_VPuYsQ@mail.gmail.com>

On Sun, Feb 19, 2017 at 2:33 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:

Show 17 quoted lines

> On Fri, Feb 17, 2017 at 9:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> I just got bitten by a fallout.  I have
>>
>>     $ git recent --help
>>     `git recent' is aliased to `log --oneline --branches --no-merges \
>>          --source --since=3.weeks'
>>
>> but now the branch names are shown at the end, which defeats the
>> whole point of the alias.
>
> Yes, your situation actually wants those decorations as primary
> things, so having them at the end is indeed pointless.
>
> So I think we should just discard that patch of mine.
>
>                  Linus

I would think that in general putting them at the end makes more sense, but we should have the ability to use them in format specifiers so that users are free to customize it exactly how they want. That is, I agree with the reasoning presented in the original patch, but think Junio's case can be solved by strengthening the custom formats.

Thanks, Jake