Re: [RFC PATCH] show decorations at the end of the line
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Feb 11, 2017, 18:13 UTC
- Message-ID
- <CA+55aFw2S14a4_4YK0b6PNK4TH_AUo_+2JN+PTyBTufNeB5t6A@mail.gmail.com>
- In-Reply-To
- <alpine.LFD.2.20.1702110943460.31350@i7.lan>
On Sat, Feb 11, 2017 at 10:02 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > I've signed off on this, because I think it's an "obvious" improvement, > but I'm putting the "RFC" in the subject line because this is clearly a > subjective thing.
Side note: the one downside of showing the decorations at the end of the line is that now they are obviously at the end of the line - and thus likely to be more hidden by things like line truncation.
The default git settings (LESS=FRX) no longer truncate log output lines, but if you use "-S" or "--chop-long-lines", you will obviously be missing the end of long lines.
So moving the decorations to the end does obviously have a real UI impact, apart from just being "prettier".
I just wanted to point that out. I still prefer decorations at ends of lines (and yes, that's despite the fact that I actually personally use the traditional git setting of "LESS=FRSX"), but it is perhaps something that people should be aware of if this patch causes discussion.
Linus