Re: [RFC PATCH] show decorations at the end of the line

From: Stephan Beyer <s-beyer@gmx.net>
Date: Feb 14, 2017, 20:36 UTC
Message-ID: <8cf9e548-bf6d-7cbc-f538-da2fbf489bc7@gmx.net>
In-Reply-To: <xmqq1sv2fq6m.fsf@gitster.mtv.corp.google.com>

Hi,

On 02/13/2017 09:30 AM, Junio C Hamano wrote:

Show 16 quoted lines

> Linus Torvalds <torvalds@linux-foundation.org> writes:
> 
>> On Sat, Feb 11, 2017 at 10:02 AM, Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>>
>>> I've signed off on this, because I think it's an "obvious" improvement,
>>> but I'm putting the "RFC" in the subject line because this is clearly a
>>> subjective thing.
>>
>> Side note: the one downside of showing the decorations at the end of
>> the line is that now they are obviously at the end of the line - and
>> thus likely to be more hidden by things like line truncation.
> 
> Side note: I refrained from commenting on this patch because
> everybody knows that the what I would say anyway ;-) and I didn't
> want to speak first to discourage others from raising their opinion.

A further side note: the current behavior of

	git log --oneline --decorate

is equivalent to

	git log --pretty='format:%C(auto)%h%d %s'

and Linus' preferred version is equivalent to

	git log --pretty='format:%C(auto)%h %s%d'

Most Git users I know have their own favorite version of git log --pretty=format:... sometimes with --graph as an alias ("git lg" or "git logk" (because its output reminds of gitk) or something).

I don't know what the main benefit of this patch would be, but if it gets accepted, it should probably be mentioned somewhere that the old behavior is easily accessible using the line mentioned above.

Cheers Stephan