Re: [RFC PATCH] show decorations at the end of the line
- From
Jeff King <peff@peff.net>
- Date
- Feb 15, 2017, 00:29 UTC
- Message-ID
- <20170215002901.gtzegvhyy7d6cvrb@sigill.intra.peff.net>
- In-Reply-To
- <xmqqr330779h.fsf@gitster.mtv.corp.google.com>
On Tue, Feb 14, 2017 at 02:11:06PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > Thanks. We'd need to update the tests that expects the old style > > output, though. > > The updates to the expectation look like this (already squashed). > The --source decorations in 4202 are also shown at the end, which > probably is in line with the way --show-decorations adds them at the > end of the line, but was somewhat surprising from reading only the > log message.
Hrm, that does surprise me. I'm not sure if that's desirable or not. I do think some of the "nobody could possibly be parsing these" arguments about decorations do not apply to --source (and also, they're harder for humans to pick out from the end of the line as they lack punctuation and color).
-Peff